qapi-commands.py: Don't call the output marshal on error
authorLuiz Capitulino <lcapitulino@redhat.com>
Wed, 19 Oct 2011 16:51:14 +0000 (14:51 -0200)
committerLuiz Capitulino <lcapitulino@redhat.com>
Thu, 27 Oct 2011 13:48:46 +0000 (11:48 -0200)
commit694a099a542563f40116743c963066ce142a7755
treedbfa59092dd4abe25963c7b70a038ad67dd811e2
parent9f60639b848944200c3d33a89233d808de0b5a43
qapi-commands.py: Don't call the output marshal on error

Today we generate something like this:

    int qmp_marshal_input_query_foo(...)

        ...

        retval = qmp_query_foo(errp);
        qmp_marshal_output_query_foo(retval, ret, errp);

        ...

However, if qmp_query_foo() fails 'retval' will probably be NULL,
which can cause a segfault as not all visitors check if 'retval'
is valid.

This commit fixes that by changing the code generator to only
call the output marshal if qmp_query_foo() succeeds, like this:

    retval = qmp_query_foo(errp);
    if (!error_is_set(errp)) {
        qmp_marshal_output_query_foo(retval, ret, errp);
    }

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
scripts/qapi-commands.py