media: vpbe_display: properly handle error case
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 6 Apr 2018 12:12:51 +0000 (08:12 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 17 Apr 2018 09:29:32 +0000 (05:29 -0400)
commit693035dcebe446897fb7a1def8b8b1606eda4131
treec4cb86441d2fad00deb458cf716f583e00b9e140
parentbef6b8947aca6cc0c0217a7650b1b970b8f9a9bb
media: vpbe_display: properly handle error case

if v4l2_subdev_call(..., VENC_GET_FLD,...) fails, it
currently returns a random value. Instead, return 1.

That's probably better than returning 0, as this is very
likely what happens in practice with the current code, as
as the probably of an unititialized 32 bits integer to
have an specific value (0, in this case), is 1/(2^32).

An alternative would be to return an error code, and
let the caller to hint, based on the past received
frame, but that sounds weird.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/davinci/vpbe_display.c