clang/Modules: Sink ASTReadResult in ReadControlBlock, NFC
authorDuncan P. N. Exon Smith <dexonsmith@apple.com>
Tue, 19 Nov 2019 22:44:22 +0000 (14:44 -0800)
committerDuncan P. N. Exon Smith <dexonsmith@apple.com>
Wed, 20 Nov 2019 00:10:44 +0000 (16:10 -0800)
commit69242e986823e3fdd11a8e51f47f36bec714363c
tree1df1a71d7fa1aaa7f5eead71b645354389264392
parent85589f8077a229a6fbc7c245ae28bec06b88c5fb
clang/Modules: Sink ASTReadResult in ReadControlBlock, NFC

Simplify the code by avoiding some state that wasn't being used.  The
function-level `Result` was only assigned a value other than `Success`
in the handler for `OPTIONS_BLOCK_ID`, but in that case it also hits an
early return.  Remove it at the function-level to make it obvious that
the normal case always returns `Success`.
clang/lib/Serialization/ASTReader.cpp