Revert "[mlir] Revisit std.subview handling of static information."
authorSam McCall <sam.mccall@gmail.com>
Tue, 12 May 2020 13:18:50 +0000 (15:18 +0200)
committerSam McCall <sam.mccall@gmail.com>
Tue, 12 May 2020 13:18:50 +0000 (15:18 +0200)
commit691e82699591d8f336cd6be52436eeff2417fab9
treed263fc4b3d95c0e1ad1fc981ad459842e6dcc932
parent7f2db993500923a51c0b0aed650a3e0d4241205b
Revert "[mlir] Revisit std.subview handling of static information."

This reverts commit 80d133b24f77d1b9d351251315606441c971ef9b.

Per Stephan Herhut: The canonicalizer pattern that was added creates
forms of the subview op that cannot be lowered.

This is shown by failing Tensorflow XLA tests such as:
  tensorflow/compiler/xla/service/mlir_gpu/tests:abs.hlo.test
Will provide more details offline, they rely on logs from private CI.
mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
mlir/lib/Dialect/StandardOps/IR/Ops.cpp
mlir/test/Conversion/StandardToLLVM/convert-to-llvmir.mlir
mlir/test/Conversion/StandardToLLVM/invalid.mlir
mlir/test/Conversion/StandardToSPIRV/legalization.mlir
mlir/test/Conversion/StandardToSPIRV/subview-to-spirv.mlir
mlir/test/Dialect/Affine/ops.mlir
mlir/test/Dialect/Linalg/promote.mlir
mlir/test/IR/core-ops.mlir
mlir/test/IR/invalid-ops.mlir
mlir/test/Transforms/canonicalize.mlir