net: sched: taprio: Fix potential integer overflow in taprio_set_picos_per_byte
authorVladimir Oltean <olteanv@gmail.com>
Sat, 28 Sep 2019 23:01:39 +0000 (02:01 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 1 Oct 2019 01:32:20 +0000 (18:32 -0700)
commit68ce6688a5baefde30914fc07fc27292dbbe8320
treeeffbc924ac1ced53a241d80025857565ffa18777
parent68501df92d116b760777a2cfda314789f926476f
net: sched: taprio: Fix potential integer overflow in taprio_set_picos_per_byte

The speed divisor is used in a context expecting an s64, but it is
evaluated using 32-bit arithmetic.

To avoid that happening, instead of multiplying by 1,000,000 in the
first place, simplify the fraction and do a standard 32 bit division
instead.

Fixes: f04b514c0ce2 ("taprio: Set default link speed to 10 Mbps in taprio_set_picos_per_byte")
Reported-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Suggested-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_taprio.c