samples/bpf: fix uninitialized warning with test_current_task_under_cgroup
authorDaniel T. Lee <danieltimlee@gmail.com>
Sun, 18 Dec 2022 06:14:53 +0000 (15:14 +0900)
committerMartin KaFai Lau <martin.lau@kernel.org>
Mon, 19 Dec 2022 22:21:05 +0000 (14:21 -0800)
commit68be98e0f4191abc64c871e3e461f275715eaf67
tree6fcebd2b0a0d50eab3042f2417678ca80303c1e5
parent71135b77aac75769f6dae81ac4725405f1015d22
samples/bpf: fix uninitialized warning with test_current_task_under_cgroup

Currently, compiling samples/bpf with LLVM warns about the uninitialized
use of variable with test_current_task_under_cgroup.

    ./samples/bpf/test_current_task_under_cgroup_user.c:57:6:
    warning: variable 'cg2' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
    if (setup_cgroup_environment())
^~~~~~~~~~~~~~~~~~~~~~~~~~
    ./samples/bpf/test_current_task_under_cgroup_user.c:106:8:
    note: uninitialized use occurs here
    close(cg2);
  ^~~
    ./samples/bpf/test_current_task_under_cgroup_user.c:57:2:
    note: remove the 'if' if its condition is always false
    if (setup_cgroup_environment())
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ./samples/bpf/test_current_task_under_cgroup_user.c:19:9:
    note: initialize the variable 'cg2' to silence this warning
    int cg2, idx = 0, rc = 1;
   ^
    = 0
    1 warning generated.

This commit resolve this compiler warning by pre-initialize the variable
with error for safeguard.

Signed-off-by: Daniel T. Lee <danieltimlee@gmail.com>
Acked-by: Yonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/r/20221218061453.6287-4-danieltimlee@gmail.com
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
samples/bpf/test_current_task_under_cgroup_user.c