thermal: intel_powerclamp: Use get_cpu() instead of smp_processor_id() to avoid crash
authorSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Tue, 20 Sep 2022 11:06:57 +0000 (04:06 -0700)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 21 Sep 2022 18:27:06 +0000 (20:27 +0200)
commit68b99e94a4a2db6ba9b31fe0485e057b9354a640
treebfb213d2d1919c3500768f36ed8ecab9d6a62962
parente9a7c526c29b0ae60c888b335bd6cf6e2ee80154
thermal: intel_powerclamp: Use get_cpu() instead of smp_processor_id() to avoid crash

When CPU 0 is offline and intel_powerclamp is used to inject
idle, it generates kernel BUG:

BUG: using smp_processor_id() in preemptible [00000000] code: bash/15687
caller is debug_smp_processor_id+0x17/0x20
CPU: 4 PID: 15687 Comm: bash Not tainted 5.19.0-rc7+ #57
Call Trace:
<TASK>
dump_stack_lvl+0x49/0x63
dump_stack+0x10/0x16
check_preemption_disabled+0xdd/0xe0
debug_smp_processor_id+0x17/0x20
powerclamp_set_cur_state+0x7f/0xf9 [intel_powerclamp]
...
...

Here CPU 0 is the control CPU by default and changed to the current CPU,
if CPU 0 offlined. This check has to be performed under cpus_read_lock(),
hence the above warning.

Use get_cpu() instead of smp_processor_id() to avoid this BUG.

Suggested-by: Chen Yu <yu.c.chen@intel.com>
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
[ rjw: Subject edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/intel/intel_powerclamp.c