cifs: fix set of group SID via NTSD xattrs
authorAmir Goldstein <amir73il@gmail.com>
Mon, 3 Jan 2022 14:50:25 +0000 (16:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Feb 2022 11:03:14 +0000 (12:03 +0100)
commit68b8924f6038bff902fd5cc63de45f5b8a8ac228
tree93e7a031c1410098a64cd5ecfb53b97dbcf96ba0
parentb4b8e7ae1346badd2836ab5323bc59f27f23ab24
cifs: fix set of group SID via NTSD xattrs

commit dd5a927e411836eaef44eb9b00fece615e82e242 upstream.

'setcifsacl -g <SID>' silently fails to set the group SID on server.

Actually, the bug existed since commit 438471b67963 ("CIFS: Add support
for setting owner info, dos attributes, and create time"), but this fix
will not apply cleanly to kernel versions <= v5.10.

Fixes: 3970acf7ddb9 ("SMB3: Add support for getting and setting SACLs")
Cc: stable@vger.kernel.org # 5.11+
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/cifs/xattr.c