crypto: sm3 - fix undefined shift by >= width of value
authorEric Biggers <ebiggers@google.com>
Wed, 9 Jan 2019 06:12:41 +0000 (22:12 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Jan 2019 20:40:31 +0000 (21:40 +0100)
commit68afc7c36461a5989b91ca88f82bbcd90dece24d
tree79ac1a751857d72080588a2896fb91aaac0945c9
parent6e09bef3cbe2c0ad2f387ce1dbfd877c97d6a029
crypto: sm3 - fix undefined shift by >= width of value

commit d45a90cb5d061fa7d411b974b950fe0b8bc5f265 upstream.

sm3_compress() calls rol32() with shift >= 32, which causes undefined
behavior.  This is easily detected by enabling CONFIG_UBSAN.

Explicitly AND with 31 to make the behavior well defined.

Fixes: 4f0fc1600edb ("crypto: sm3 - add OSCCA SM3 secure hash")
Cc: <stable@vger.kernel.org> # v4.15+
Cc: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
crypto/sm3_generic.c