power: supply: s3c_adc_battery: fix possible use-after-free in s3c_adc_bat_remove()
authorYang Yingliang <yangyingliang@huawei.com>
Wed, 7 Apr 2021 09:19:03 +0000 (17:19 +0800)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Thu, 8 Apr 2021 12:36:08 +0000 (14:36 +0200)
commit68ae256945d2abe9036a7b68af4cc65aff79d5b7
tree4f77a136af48a64057ebe186101692f4fe0564ef
parentb6cfa007b3b229771d9588970adb4ab3e0487f49
power: supply: s3c_adc_battery: fix possible use-after-free in s3c_adc_bat_remove()

This driver's remove path calls cancel_delayed_work(). However, that
function does not wait until the work function finishes. This means
that the callback function may still be running after the driver's
remove function has finished, which would result in a use-after-free.

Fix by calling cancel_delayed_work_sync(), which ensures that
the work is properly cancelled, no longer running, and unable
to re-schedule itself.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/s3c_adc_battery.c