Change calls from string.IndexOf to string.Contains (CoreFX) (dotnet/corefx#32249)
authorGrant <grant@jesanna.com>
Thu, 13 Sep 2018 22:20:39 +0000 (15:20 -0700)
committerDan Moseley <danmose@microsoft.com>
Thu, 13 Sep 2018 22:20:39 +0000 (15:20 -0700)
commit6898a1f9a2a120e9367c3999d30362b34307b0ad
treed95f020ac00b014b2859e0cba77ba8c28d5a52ac
parentd2232d7780388177f1802d316437e797b2dbd244
Change calls from string.IndexOf to string.Contains (CoreFX) (dotnet/corefx#32249)

* Update call sites

* More call sites

* Another callsite

* More call sites

* CR fixes - revert src/Common/src/CoreLib/*

* Spurious fix

* Revert string.Contains where platform may not be NetCore21

* nit

* More reverts

* More reverts

* More reverts

* Revert

* Remove comments

* Revert

Commit migrated from https://github.com/dotnet/corefx/commit/6ffca612323448f1488a6c63b86b69611b4286d9
36 files changed:
src/libraries/Common/src/Interop/Unix/System.Native/Interop.ReadDir.cs
src/libraries/Common/src/System/CodeDom/CodeTypeReference.cs
src/libraries/Common/src/System/Data/Common/DbConnectionOptions.Common.cs
src/libraries/Microsoft.Win32.Registry/src/Microsoft/Win32/RegistryKey.cs
src/libraries/System.CodeDom/src/Microsoft/CSharp/CSharpCodeGenerator.cs
src/libraries/System.CodeDom/src/Microsoft/VisualBasic/VBCodeGenerator.cs
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/EnumConverter.cs
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/SyntaxCheck.cs
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/BaseConfigurationRecord.cs
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationProperty.cs
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationSectionCollection.cs
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationSectionGroupCollection.cs
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/TypeUtil.cs
src/libraries/System.Data.Common/src/System/Data/Common/DBCommandBuilder.cs
src/libraries/System.Data.Common/src/System/Data/Common/DbConnectionOptions.cs
src/libraries/System.Data.Common/src/System/Data/XMLSchema.cs
src/libraries/System.Data.Odbc/src/Common/System/Data/Common/DbConnectionOptions.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlConnectionString.cs
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpSystemProxy.cs
src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpEndPointManager.cs
src/libraries/System.Net.NetworkInformation/src/System/Net/NetworkInformation/PhysicalAddress.cs
src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs
src/libraries/System.Net.WebHeaderCollection/src/System/Net/HeaderInfoTable.cs
src/libraries/System.Private.Uri/src/System/UriBuilder.cs
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlTextReaderImpl.cs
src/libraries/System.Private.Xml/src/System/Xml/Core/XsdCachingReader.cs
src/libraries/System.Private.Xml/src/System/Xml/Schema/DtdParser.cs
src/libraries/System.Private.Xml/src/System/Xml/Schema/DtdParserAsync.cs
src/libraries/System.Private.Xml/src/System/Xml/Schema/FacetChecker.cs
src/libraries/System.Private.Xml/src/System/Xml/Serialization/SoapReflectionImporter.cs
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlReflectionImporter.cs
src/libraries/System.Private.Xml/src/System/Xml/Serialization/Xmlcustomformatter.cs
src/libraries/System.Runtime.Extensions/src/System/Environment.Windows.cs
src/libraries/System.ServiceProcess.ServiceController/src/System/ServiceProcess/ServiceController.cs
src/libraries/System.Transactions.Local/src/System/Transactions/TransactionsEtwProvider.cs
src/libraries/System.Web.HttpUtility/src/System/Web/Util/HttpEncoderUtility.cs