i965/fs: Don't perform CSE on inst HW_REG dests (unless it's null)
authorMatt Turner <mattst88@gmail.com>
Thu, 7 Nov 2013 23:09:33 +0000 (15:09 -0800)
committerMatt Turner <mattst88@gmail.com>
Sat, 9 Nov 2013 17:10:24 +0000 (09:10 -0800)
commit68349e52194b7eba521b88d42ee8db3bfdf0a877
treeac2f758a202d3419bb95d6c134d4198fe40ab37d
parentb7dfb8528fd4c62218ea5c0a670d939c8d49e651
i965/fs: Don't perform CSE on inst HW_REG dests (unless it's null)

Commit b16b3c87 began performing CSE on CMP instructions with null
destinations. I relaxed the restrictions a bit too much, thereby
allowing CSE to be performed on instructions with, for instance, an
explicit accumulator destination.

This broke the arb_gpu_shader5/fs-imulExtended shader tests because
they emit MUL instructions with the accumulator as the destination. CSE
would instead cause the MUL to write to a GRF, which is lower precision
than the accumulator.

Reviewed-by: Eric Anholt <eric@anholt.net>
Cc: 10.0 <mesa-stable@lists.freedesktop.org>
src/mesa/drivers/dri/i965/brw_fs_cse.cpp