net: microchip: sparx5: Fix error handling in vcap_show_admin()
authorDan Carpenter <error27@gmail.com>
Tue, 29 Nov 2022 09:43:47 +0000 (12:43 +0300)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 1 Dec 2022 11:12:23 +0000 (12:12 +0100)
commit682f560b8a87bfdf174e836640e6ec66a2b3cd9c
treeb4286c716fd01ff5746111e75d7bc714d6480a77
parente5214f363dabca240446272dac54d404501ad5e5
net: microchip: sparx5: Fix error handling in vcap_show_admin()

If vcap_dup_rule() fails that leads to an error pointer dereference
side the call to vcap_free_rule().  Also it only returns an error if the
very last call to vcap_read_rule() fails and it returns success for
other errors.

I've changed it to just stop printing after the first error and return
an error code.

Fixes: 3a7921560d2f ("net: microchip: sparx5: Add VCAP rule debugFS support for the VCAP API")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
Link: https://lore.kernel.org/r/Y4XUUx9kzurBN+BV@kili
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/microchip/vcap/vcap_api_debugfs.c