Re-enable xunit warning 2002 dotnet/corefx#39696 (dotnet/corefx#39706)
authorZoey McCullough <zoey.c.mccullough@gmail.com>
Fri, 26 Jul 2019 13:58:06 +0000 (06:58 -0700)
committerStephen Toub <stoub@microsoft.com>
Fri, 26 Jul 2019 13:58:06 +0000 (09:58 -0400)
commit6820071ac0c74f43d7d3f575f89eea2c0d921307
treea81ee5435ede786fe906c1ad01609524c53dd4fe
parente1b64fb63db00e756073862ff2d7d1ee8929a8c4
Re-enable xunit warning 2002 dotnet/corefx#39696 (dotnet/corefx#39706)

* Removed null checks on value types and enabled xunit 2002

* Updated Fill_OpenDataReader_Throws to use range check

Updated Fill_OpenDataReader_Throws to use range check for passing path

* Removed uneeded asserts and updated others

- Removed any assert for a valuetype where it was succeeded by a value type assertion (e.g. Assert.Equal(1, 1))
- Updated reflection tests to check flags for the specified scenario

* Update src/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs

Co-Authored-By: Jeremy Barton <jbarton@microsoft.com>
* Update src/System.Reflection/tests/AssemblyNameTests.cs

Co-Authored-By: Jeremy Barton <jbarton@microsoft.com>
* Fixed failing reflection tests and removed Assert.NotNull for enum

* Pulled ruleset up from master to merge

* Cleaned up assert ordering for TestGuid

* Updated TestResponseWithoutContentEvents

- Asserted for 200 OK based on response from DefaultAzureServer + EmptyContentHandler

Commit migrated from https://github.com/dotnet/corefx/commit/c96e389f803b043753558878fefb575f3f85c934
19 files changed:
src/libraries/CodeAnalysis.ruleset
src/libraries/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs
src/libraries/System.Collections.Specialized/tests/BitVector32Tests.cs
src/libraries/System.Configuration.ConfigurationManager/tests/System/Configuration/SettingElementTests.cs
src/libraries/System.Data.OleDb/tests/OleDbDataAdapterTests.cs
src/libraries/System.Diagnostics.DiagnosticSource/tests/HttpHandlerDiagnosticListenerTests.cs
src/libraries/System.Diagnostics.EventLog/tests/System/Diagnostics/Reader/ProviderMetadataTests.cs
src/libraries/System.IO.Pipelines/tests/PipePoolTests.nonnetstandard.cs
src/libraries/System.Net.Sockets/tests/FunctionalTests/DualModeSocketTest.cs
src/libraries/System.Net.Sockets/tests/FunctionalTests/UdpClientTest.cs
src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.RuntimeOnly.cs
src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs
src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/TypeInfoFromProjectN/TypeInfo_PropertyTests.cs
src/libraries/System.Reflection/tests/AssemblyNameTests.cs
src/libraries/System.Reflection/tests/MethodInfoTests.cs
src/libraries/System.Runtime.Extensions/tests/System/Environment.GetEnvironmentVariable.cs
src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs
src/libraries/System.Runtime.Serialization.Json/tests/DataContractJsonSerializer.cs
src/libraries/System.Text.Json/tests/Serialization/ExtensionDataTests.cs