drm/msm: fix use-after-free on probe deferral
authorJohan Hovold <johan+linaro@kernel.org>
Tue, 13 Sep 2022 08:53:11 +0000 (10:53 +0200)
committerAbhinav Kumar <quic_abhinavk@quicinc.com>
Fri, 30 Sep 2022 16:57:53 +0000 (16:57 +0000)
commit6808abdb33bf90330e70a687d29f038507e06ebb
tree162519a0b94148b3af5d4f08e94c089441b0bea7
parent0b33a33bd15d5bab73b87152b220a8d0153a4587
drm/msm: fix use-after-free on probe deferral

The bridge counter was never reset when tearing down the DRM device so
that stale pointers to deallocated structures would be accessed on the
next tear down (e.g. after a second late bind deferral).

Given enough bridges and a few probe deferrals this could currently also
lead to data beyond the bridge array being corrupted.

Fixes: d28ea556267c ("drm/msm: properly add and remove internal bridges")
Fixes: a3376e3ec81c ("drm/msm: convert to drm_bridge")
Cc: stable@vger.kernel.org # 3.12
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Tested-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
Reviewed-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/502665/
Link: https://lore.kernel.org/r/20220913085320.8577-2-johan+linaro@kernel.org
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
drivers/gpu/drm/msm/msm_drv.c