efi/arm: Don't expect a return value of ptdump_debugfs_register
authorNathan Chancellor <natechancellor@gmail.com>
Fri, 1 Feb 2019 19:20:01 +0000 (12:20 -0700)
committerCatalin Marinas <catalin.marinas@arm.com>
Mon, 4 Feb 2019 16:53:30 +0000 (16:53 +0000)
commit67f52a9540e08d3fd98d6588d75d0eb9157b2534
treebc6019cb0271d4400d002936471e03f4c07b8fa2
parentd0a060be573bfbf8753a15dca35497db5e968bb0
efi/arm: Don't expect a return value of ptdump_debugfs_register

As of commit e2a2e56e4082 ("arm64: dump: no need to check return value
of debugfs_create functions") in the arm64 for-next/core branch,
ptdump_debugfs_register does not have a return value, which causes a
build error here:

drivers/firmware/efi/arm-runtime.c:51:9: error: returning 'void' from a
function with incompatible result type 'int'
        return ptdump_debugfs_register(&efi_ptdump_info, "efi_page_tables");
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

The arm version is still awaiting acceptance [1] but in anticipation
of that patch being merged, restructure this function to call
ptdump_debugfs_register without expecting a return value.

[1]: https://lore.kernel.org/lkml/20190122144114.9816-3-gregkh@linuxfoundation.org/

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
drivers/firmware/efi/arm-runtime.c