c-family: ICE with [[gnu::nocf_check]] [PR106937]
authorMarek Polacek <polacek@redhat.com>
Thu, 29 Sep 2022 21:49:32 +0000 (17:49 -0400)
committerMarek Polacek <polacek@redhat.com>
Mon, 10 Oct 2022 18:16:44 +0000 (14:16 -0400)
commit67efffec943656a509e036cd3c785a5c3d6885e1
tree11e066be82c3dc664f3c67e9dfeb79a51dfc7113
parent248c8aeebc49aae3fd96bd587367d12e7c8b3c3a
c-family: ICE with [[gnu::nocf_check]] [PR106937]

When getting the name of an attribute, we ought to use
get_attribute_name, which handles both [[]] and __attribute__(())
forms.  Failure to do so may result in an ICE, like here.

pp_c_attributes_display wasn't able to print the [[]] form of
attributes, so this patch teaches it to.

When printing a pointer to function with a standard attribute, the attribute
should be printed after the parameter-list.  With this patch we print:

  aka 'void (*)(int) [[gnu::nocf_check]]'

or, in C++ with noexcept:

  aka 'void (*)(int) noexcept [[gnu::nocf_check]]'

pp_c_attributes has been unused since its introduction in r56273 so
this patch removes it.

PR c++/106937

gcc/c-family/ChangeLog:

* c-pretty-print.cc (pp_c_specifier_qualifier_list): Print only GNU
attributes here.
(c_pretty_printer::direct_abstract_declarator): Print the standard [[]]
attributes here.
(pp_c_attributes): Remove.
(pp_c_attributes_display): Print the [[]] form if appropriate.  Use
get_attribute_name.  Don't print a trailing space when printing the
[[]] form.
* c-pretty-print.h (pp_c_attributes): Remove.

gcc/cp/ChangeLog:

* error.cc: Include "attribs.h".
(dump_type_prefix): Print only GNU attributes here.
(dump_type_suffix): Print standard attributes here.

gcc/testsuite/ChangeLog:

* c-c++-common/pointer-to-fn1.c: New test.
gcc/c-family/c-pretty-print.cc
gcc/c-family/c-pretty-print.h
gcc/cp/error.cc
gcc/testsuite/c-c++-common/pointer-to-fn1.c [new file with mode: 0644]