Switch SkPDFStream's internal storage from SkStream to SkData
authorhalcanary <halcanary@google.com>
Fri, 27 Jun 2014 18:36:20 +0000 (11:36 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 27 Jun 2014 18:36:20 +0000 (11:36 -0700)
commit67ec1f8eecfb48bc0a6ba04c0057f103c1c9696f
tree44826f6816c7d0ca8f1fdd7f92e2a70f0dd33e1d
parent89443aba5bfa2b040dc9fd24938b7d0b3decd737
Switch SkPDFStream's internal storage from SkStream to SkData

Motivation: This makes SkPDFStream thread-safe for two threads
serializing it at once, since a SkStream has an internal position.

Updated SkPDFFont, SkPDFGraphicState, and SkPDFPage's use of
SkPDFStream to use the SkData constructor rather than the SkStream
constructor (saving a memcpy).

BUG=skia:2683

Committed: https://skia.googlesource.com/skia/+/c1dfa14b645ae274780f026dd86c9b633fbdad06

R=mtklein@google.com, djsollen@google.com, rmistry@google.com, robertphillips@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/340783013
16 files changed:
gyp/core.gypi
gyp/images.gyp
src/core/SkStream.cpp
src/core/SkStreamPriv.h [moved from src/images/SkStreamHelpers.h with 69% similarity]
src/images/SkImageDecoder_ktx.cpp
src/images/SkImageDecoder_libbmp.cpp
src/images/SkImageDecoder_libico.cpp
src/images/SkImageDecoder_pkm.cpp
src/images/SkStreamHelpers.cpp [deleted file]
src/pdf/SkPDFFont.cpp
src/pdf/SkPDFGraphicState.cpp
src/pdf/SkPDFImage.cpp
src/pdf/SkPDFPage.cpp
src/pdf/SkPDFStream.cpp
src/pdf/SkPDFStream.h
src/ports/SkImageDecoder_CG.cpp