USB: fix linked-list corruption in rh_call_control()
authorAlan Stern <stern@rowland.harvard.edu>
Fri, 24 Mar 2017 17:38:28 +0000 (13:38 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 8 Apr 2017 07:30:34 +0000 (09:30 +0200)
commit67e41b1368b146ff6508a4efe5552400412d2f32
tree969f81d050866fd8687f7b0499ee530781b506a3
parent1f1c9e29651df61516b028c58632124b345ec85b
USB: fix linked-list corruption in rh_call_control()

commit 1633682053a7ee8058e10c76722b9b28e97fb73f upstream.

Using KASAN, Dmitry found a bug in the rh_call_control() routine: If
buffer allocation fails, the routine returns immediately without
unlinking its URB from the control endpoint, eventually leading to
linked-list corruption.

This patch fixes the problem by jumping to the end of the routine
(where the URB is unlinked) when an allocation failure occurs.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-and-tested-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/hcd.c