playsink: Fix reconfiguration after removing text_sink
authorJan Schmidt <jan@centricular.com>
Wed, 10 Nov 2021 16:20:23 +0000 (03:20 +1100)
committerEdward Hervey <bilboed@bilboed.com>
Fri, 11 Mar 2022 14:02:01 +0000 (15:02 +0100)
commit67dbe75703497c985c35f9d8ac88d7667484475c
treebe706559f89cf32536b5f66a207a319b06dbc2c6
parentecfc93a01877dcb4d6850aa5997eafab6fdbfd7e
playsink: Fix reconfiguration after removing text_sink

If we previously had subtitles coming in, the video
may be chained through a text overlay block. Before,
the code would end up trying to link pads that were
already linked and video would not get reconnected
properly.

To fix that, make sure that the candidate
pads are actually unlinked first. If a textoverlay
is present and no longer needed, it will be cleaned
up later in the reconfiguration sequence.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1900>
subprojects/gst-plugins-base/gst/playback/gstplaysink.c