Guard against killing unrelated processes in amd64-disp-step.exp
authorRainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Tue, 8 Aug 2023 08:13:58 +0000 (10:13 +0200)
committerRainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Tue, 8 Aug 2023 08:13:58 +0000 (10:13 +0200)
commit67be0489f28161239442dae38d4a14a38cb824de
tree7484514ce53a86950ec1b845cda26b5700236579
parentaaa1d4b8f227c29f27a13a4a14622f0a3499e4b9
Guard against killing unrelated processes in amd64-disp-step.exp

When testing current gdb trunk on Solaris/amd64, the whole session was
reliably terminated by make check.  I could trace this to the following
entry in gdb.arch/amd64-disp-step/gdb.log:

FAIL: gdb.arch/amd64-disp-step.exp: add into rcx: send_signal=on: get
inferior pid
Executing on target: kill -ALRM -1    (timeout = 300)
builtin_spawn -ignore SIGHUP kill -ALRM -1

If $inferior_pid doesn't refer to a single process for some reason, this
kill would terminate either a process group or the whole session.

This patch avoids this by ensuring that the pid arg is positive.

Tested on amd64-pc-solaris2.11 and x86_64-pc-linux-gnu.

Co-Authored-By: Andrew Burgess <aburgess@redhat.com>
Approved-By: Tom Tromey <tom@tromey.com>
gdb/testsuite/gdb.arch/amd64-disp-step.exp