r600/sfn; go back to not lowering uniforms to UBOs
authorGert Wollny <gert.wollny@collabora.com>
Sat, 26 Sep 2020 18:14:00 +0000 (20:14 +0200)
committerMarge Bot <eric+marge@anholt.net>
Mon, 28 Sep 2020 18:16:29 +0000 (18:16 +0000)
commit6784cea646b0d5f7dde4827b52ea269f53210d67
treed7ad53d780d434fe904117b478118fb7a5274c9b
parent9a6b11a7330b08f57876bd8b16c3b360e4818e86
r600/sfn; go back to not lowering uniforms to UBOs

Lowering uniforms to UBOs results in an aditional iadd for the
UBO buffer id evaluation, and for indirect buffers access that
results in an unnecessary op that can be avoided by not lowering
uniforms. There is some code duplication when reading the uniforms
but it saves a whole instruction group per indirect cont buffer
access.

This reverts commit 98eb00face93b9af5aac19008ecff5a2bf376745 with
some additional fixes.

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6879>
src/gallium/drivers/r600/r600_pipe_common.c
src/gallium/drivers/r600/sfn/sfn_shader_base.cpp
src/gallium/drivers/r600/sfn/sfn_shader_base.h
src/gallium/drivers/r600/sfn/sfn_value.cpp