[lldb][NFCI] Remove unneeded use of ConstString in ASTResultSynthesizer
authorAlex Langford <alangford@apple.com>
Tue, 27 Jun 2023 18:37:22 +0000 (11:37 -0700)
committerAlex Langford <alangford@apple.com>
Mon, 3 Jul 2023 16:31:10 +0000 (09:31 -0700)
commit673f91055a41b2273e159eafe86d0d7d87fa474f
treef1760bcb7db7474e65f307e769fc7d635c8495be
parent7871deb8213c2162e6234537f334ff6b11257b23
[lldb][NFCI] Remove unneeded use of ConstString in ASTResultSynthesizer

2/3 of the ConstStrings in this class were just to be able to log
something. Putting something in the StringPool just to log it doesn't
make a lot of sense, so let's remove them.

The remaining use is for `RegisterPersistentDecl` which is fine for now.

Differential Revision: https://reviews.llvm.org/D153905
lldb/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp