[mlir][vector] modified scatter/gather syntax, pass_thru mandatory
authorAart Bik <ajcbik@google.com>
Sat, 9 Jan 2021 00:25:37 +0000 (16:25 -0800)
committerAart Bik <ajcbik@google.com>
Sat, 9 Jan 2021 19:41:37 +0000 (11:41 -0800)
commit6728af16cf987df3cf051f3a1f9c92ed2b8fbc2d
treedf9c5fe346bd0dbf07e87fb8c31aa5498fb9c69b
parentd98fc62ae68cd7e96bf6e85b7fbbee969cec9aa7
[mlir][vector] modified scatter/gather syntax, pass_thru mandatory

This change makes the scatter/gather syntax more consistent with
the syntax of all the other memory operations in the Vector dialect
(order of types, use of [] for index, etc.). This will make the MLIR
code easier to read. In addition, the pass_thru parameter of the
gather has been made mandatory (there is very little benefit in
using the implicit "undefined" values).

Reviewed By: nicolasvasilache

Differential Revision: https://reviews.llvm.org/D94352
mlir/include/mlir/Dialect/Vector/VectorOps.td
mlir/integration_test/Dialect/Vector/CPU/test-gather.mlir
mlir/integration_test/Dialect/Vector/CPU/test-scatter.mlir
mlir/integration_test/Dialect/Vector/CPU/test-sparse-dot-matvec.mlir
mlir/integration_test/Dialect/Vector/CPU/test-sparse-saxpy-jagged-matvec.mlir
mlir/lib/Dialect/Vector/VectorOps.cpp
mlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir
mlir/test/Dialect/Vector/invalid.mlir
mlir/test/Dialect/Vector/ops.mlir
mlir/test/Dialect/Vector/vector-mem-transforms.mlir