ALSA: emu10k1: remove superfluous IRQ enable state saving
authorOswald Buddenhagen <oswald.buddenhagen@gmx.de>
Wed, 12 Jul 2023 14:57:49 +0000 (16:57 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 13 Jul 2023 08:30:06 +0000 (10:30 +0200)
commit67192cc0f0263847ab3ccdcfe90989624a0c7fe3
tree7ef0f6171d6e36319149861d53c92941f2f36ba6
parentdeb1200f6eb634a6e4d08ada953b72be1e8adcfa
ALSA: emu10k1: remove superfluous IRQ enable state saving

The mixer, PCM prepare, MIDI, synth driver, and procfs callbacks are all
always invoked with IRQs enabled, so there is no point in saving the
state.

snd_emu1010_load_firmware_entry() is called from emu1010_firmware_work()
and snd_emu10k1_emu1010_init(); the latter from snd_emu10k1_create() and
snd_emu10k1_resume(), all of which have IRQs enabled.

The voice and memory functions are called from mixed contexts, so they
keep the state saving.

The low-level functions all keep the state saving, because it's not
feasible to keep track of what is called where.

Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Link: https://lore.kernel.org/r/20230712145750.125086-2-oswald.buddenhagen@gmx.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/emu10k1/emu10k1_main.c
sound/pci/emu10k1/emu10k1_synth.c
sound/pci/emu10k1/emumixer.c
sound/pci/emu10k1/emumpu401.c
sound/pci/emu10k1/emupcm.c
sound/pci/emu10k1/emuproc.c