io-wq: serialize hash clear with wakeup
authorJens Axboe <axboe@kernel.dk>
Fri, 12 Nov 2021 00:32:53 +0000 (17:32 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Nov 2021 18:16:07 +0000 (19:16 +0100)
commit670f1f30ed706e192448a6b3f4f0af73fdc22591
tree48a9de1b0c472b3cf9a80374e2f7f2d67b24d7d6
parent5bfa57795dc13b28375a5780914c8ae34dab44cc
io-wq: serialize hash clear with wakeup

commit d3e3c102d107bb84251455a298cf475f24bab995 upstream.

We need to ensure that we serialize the stalled and hash bits with the
wait_queue wait handler, or we could be racing with someone modifying
the hashed state after we find it busy, but before we then give up and
wait for it to be cleared. This can cause random delays or stalls when
handling buffered writes for many files, where some of these files cause
hash collisions between the worker threads.

Cc: stable@vger.kernel.org
Reported-by: Daniel Black <daniel@mariadb.org>
Fixes: e941894eae31 ("io-wq: make buffered file write hashed work map per-ctx")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/io-wq.c