bpf: Propagate error from htab_lock_bucket() to userspace
authorHou Tao <houtao1@huawei.com>
Wed, 31 Aug 2022 04:26:28 +0000 (12:26 +0800)
committerMartin KaFai Lau <martin.lau@kernel.org>
Wed, 31 Aug 2022 21:10:01 +0000 (14:10 -0700)
commit66a7a92e4d0d091e79148a4c6ec15d1da65f4280
tree98ec0e1fb6c9359d6b586aa44ea44b4309f74f23
parent2775da21628738ce073a3a6a806adcbaada0f091
bpf: Propagate error from htab_lock_bucket() to userspace

In __htab_map_lookup_and_delete_batch() if htab_lock_bucket() returns
-EBUSY, it will go to next bucket. Going to next bucket may not only
skip the elements in current bucket silently, but also incur
out-of-bound memory access or expose kernel memory to userspace if
current bucket_cnt is greater than bucket_size or zero.

Fixing it by stopping batch operation and returning -EBUSY when
htab_lock_bucket() fails, and the application can retry or skip the busy
batch as needed.

Fixes: 20b6cc34ea74 ("bpf: Avoid hashtab deadlock with map_locked")
Reported-by: Hao Sun <sunhao.th@gmail.com>
Signed-off-by: Hou Tao <houtao1@huawei.com>
Link: https://lore.kernel.org/r/20220831042629.130006-3-houtao@huaweicloud.com
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
kernel/bpf/hashtab.c