rtc: efi: Avoid spamming the log on RTC read failure
authorArd Biesheuvel <ardb@kernel.org>
Fri, 17 Feb 2023 14:23:38 +0000 (15:23 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Wed, 22 Feb 2023 20:07:53 +0000 (21:07 +0100)
commit668a2abf91143caa226b3ccd0bd4d79ea85935a6
treeb02962f76da3b0c2ad123a8425336083bf8127c7
parent303eac653a181be59674920725142cfbdd5ba4cd
rtc: efi: Avoid spamming the log on RTC read failure

There are cases where the EFI runtime services may end up in a funny
state, e.g., due to a crash in the variable services, and this affects
other EFI runtime services as well.

That means that, even though GetTime() should not return an error, there
are cases where it might, and there is no point in logging such an
occurrence multiple times.

This works around an issue where user space -apparently- keeps hitting
on /dev/rtc if it fails to read the h/w clock, resulting in a tsunami of
log spam and a non-responsive system as a result.

Cc: Pierre Gondois <pierre.gondois@arm.com>
Cc: Alexandru Elisei <alexandru.elisei@arm.com>
Link: https://lore.kernel.org/all/Y2o1hdZK9GGDVJsS@monolith.localdoman/
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20230217142338.1444509-1-ardb@kernel.org
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-efi.c