crypto: x86/morus - fix handling chunked inputs and MAY_SLEEP
authorEric Biggers <ebiggers@google.com>
Fri, 1 Feb 2019 07:51:39 +0000 (23:51 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Mar 2019 19:09:55 +0000 (20:09 +0100)
commit66700c89f0ab3f210b58ebb3c53a736546d7c2d5
tree19b55f5943957be0c9c61676630c2bb034e12611
parent8a9fcf4a9f1f5f756f50e558df2da790e2936cf0
crypto: x86/morus - fix handling chunked inputs and MAY_SLEEP

commit 2060e284e9595fc3baed6e035903c05b93266555 upstream.

The x86 MORUS implementations all fail the improved AEAD tests because
they produce the wrong result with some data layouts.  The issue is that
they assume that if the skcipher_walk API gives 'nbytes' not aligned to
the walksize (a.k.a. walk.stride), then it is the end of the data.  In
fact, this can happen before the end.

Also, when the CRYPTO_TFM_REQ_MAY_SLEEP flag is given, they can
incorrectly sleep in the skcipher_walk_*() functions while preemption
has been disabled by kernel_fpu_begin().

Fix these bugs.

Fixes: 56e8e57fc3a7 ("crypto: morus - Add common SIMD glue code for MORUS")
Cc: <stable@vger.kernel.org> # v4.18+
Cc: Ondrej Mosnacek <omosnace@redhat.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Ondrej Mosnacek <omosnace@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/x86/crypto/morus1280_glue.c
arch/x86/crypto/morus640_glue.c