nvme-loop: kill timeout handler
authorMing Lei <ming.lei@redhat.com>
Mon, 15 Apr 2019 01:51:46 +0000 (09:51 +0800)
committerChristoph Hellwig <hch@lst.de>
Thu, 25 Apr 2019 14:51:41 +0000 (16:51 +0200)
commit663d6fee66b555f6a080104751be0b54e0bca78a
tree1ebcff4898222daab69984816a6e7a8cea36b4e5
parentefb973b19b88642bb7e08b8ce8e03b0bbd2a7e2a
nvme-loop: kill timeout handler

Firstly it doesn't make sense to handle timeout for loop: 1) for admin
queue, the request is always completed in code path of queuing IO. 2)
for normal IO request, the timeout on these IOs have been handled by
underlying queue already.

Secondly nvme-loop's timeout handler is simply broken, and easy to
cause issue: 1) no any sync/protection between timeout and normal
completion, and now it is driver's responsibility to deal with
that; 2) bad reset implementation, blk_mq_update_nr_hw_queues()
is called after all NSs's queue is stopped(quiesced), and easy
to trigger deadlock.

So kill the timeout handler.

Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewd-by: Keith Busch <keith.busch@intel.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/target/loop.c