regulator: bd718x7: Use dev_err_probe()
authorMatti Vaittinen <mazziesaccount@gmail.com>
Wed, 23 Nov 2022 12:00:38 +0000 (14:00 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 23 Nov 2022 13:09:06 +0000 (13:09 +0000)
commit662a9bf883f42d09145cf083d93dadf0307f15ea
tree10295a45a4f6598e5570ccde333aa3b021144d8d
parentd4e93e8da012880882671a46ac6ae3aefcae8076
regulator: bd718x7: Use dev_err_probe()

The dev_err_probe() has (at least) following benefits over dev_err()
when printing an error print for a failed function call at a device
driver probe:
        - Omit error level print if error is 'EPRBE_DEFER'
        - Standardized print format for returned error
        - return the error value allowing shortening calls like:

        if (ret) {
                dev_err(...);
                return ret;
        }

        to

        if (ret)
                return dev_err_probe(...);

Convert the ROHM BD718x7 regulator driver to use the dev_err_probe() when
returned error is not hard-coded constant.

NOTE:
This commit also changes the error handling path to return immediately
from a spot where the error is spotted instead of using a single point
of exit.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Link: https://lore.kernel.org/r/fee54c2d04bb41b51381e31523f9ed31575206d2.1669203610.git.mazziesaccount@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/bd718x7-regulator.c