spi: pxa2xx: Fix runtime PM ref imbalance on probe error
authorLukas Wunner <lukas@wunner.de>
Mon, 25 May 2020 12:25:03 +0000 (14:25 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 26 May 2020 14:40:31 +0000 (15:40 +0100)
commit65e318e17358a3fd4fcb5a69d89b14016dee2f06
treee116a5359e54508bab7a413fd81b3885b9fffde2
parent32e5b57232c0411e7dea96625c415510430ac079
spi: pxa2xx: Fix runtime PM ref imbalance on probe error

The PXA2xx SPI driver releases a runtime PM ref in the probe error path
even though it hasn't acquired a ref earlier.

Apparently commit e2b714afee32 ("spi: pxa2xx: Disable runtime PM if
controller registration fails") sought to copy-paste the invocation of
pm_runtime_disable() from pxa2xx_spi_remove(), but erroneously copied
the call to pm_runtime_put_noidle() as well.  Drop it.

Fixes: e2b714afee32 ("spi: pxa2xx: Disable runtime PM if controller registration fails")
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: stable@vger.kernel.org # v4.17+
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Link: https://lore.kernel.org/r/58b2ac6942ca1f91aaeeafe512144bc5343e1d84.1590408496.git.lukas@wunner.de
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pxa2xx.c