staging: rtl8188eu: use prefix decrement operator on trycnt variable
authorPhillip Potter <phil@philpotter.co.uk>
Tue, 15 Jun 2021 22:36:02 +0000 (23:36 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Jun 2021 07:25:29 +0000 (09:25 +0200)
commit65df1d15d0734eea98f9084802a43d4f923ad65e
treed99b0705d9082e9ace7c6138b9a5146b4f70e2da
parent0ef5dec44aea0083a77fb0120a9a7a86f203e61d
staging: rtl8188eu: use prefix decrement operator on trycnt variable

Modify trycnt condition in the do/while loop of rtw_hal_set_hwreg to use
a prefix decrement operator instead of postfix. As an unsigned 8-bit
integer, this value would actually be 255 after the end of the do/while
loop, which is almost certainly not what was intended. It is more
reasonable to assume a loop counter should be zero at the end of all
loop iterations. Indeed, the line following the loop previously contained
an if statement which assumed trycnt was 0, and therefore was never
triggered.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210615223607.13863-3-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/hal/usb_halinit.c