staging: rtl8723bs: remove unused BIT macros definitions
authorFabio Aiuto <fabioaiuto83@gmail.com>
Fri, 30 Jul 2021 13:40:48 +0000 (15:40 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 30 Jul 2021 14:06:32 +0000 (16:06 +0200)
commit658dfbec96620ff08ef17c87b35b6a6bb8d52fc0
treeb6ed1c77a4f4c86ad170e8a06d8048e6fedf66de
parentd8062f6adca1ef13a0bab70ddcd67881d483338e
staging: rtl8723bs: remove unused BIT macros definitions

BIT(x) macro used all over the driver is defined in
include/vsdo/bit.h as

- #define BIT(nr) (UL(1) << (nr))

which is safer than the local BIT macros declared.
Local macros shift a signed integer which brings
unespected results. For example:

(unsigned long)(1 << 31) => 0xffffffff80000000

shift.c:

int main() {
        printf("%lx\n", (unsigned long)(1 << 31));
        printf("%lx\n", (unsigned long)(1U << 31));
        return 0;
}

...

$ ./shift
ffffffff80000000
80000000

...

So just remove redundant, less safe macro declarations.

Suggested-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/20210730134048.8736-1-fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/include/osdep_service.h
drivers/staging/rtl8723bs/include/wifi.h