Remove duplicated ILLink PackageReference and update target version of the SDK to...
authorViktor Hofer <viktor.hofer@microsoft.com>
Thu, 25 Feb 2021 10:23:21 +0000 (11:23 +0100)
committerGitHub <noreply@github.com>
Thu, 25 Feb 2021 10:23:21 +0000 (11:23 +0100)
commit653b3103d197075e0a4efbc7450b0d0fceff8fff
treebcf79552549a1a9d8e29136a21bcbd745c1c9c60
parent12ec2197ed3999c98f49c006a27ee761282df168
Remove duplicated ILLink PackageReference and update target version of the SDK to 6.0 (#48462)

* Remove duplicated ILLink PackageReference

The Arcade.SDK already package refrences the ILLink package. The
duplicate reference in illink.targets caused SDK errors as the Arcade
reference has IsImplicitlyDefined set which doesn't allow an additional
reference with the same identity.

Also, as the ILLink package already exposes the path to the assembly via
its props file, using that instead of manually constructing the path to
the assembly.

The SDK target version update is required as the sequencing of the
ILLink.props file was wrong and is required for this change. This isn't
considered a breaking change, as the SDK's minimum required version
isn't changed.

* Update arcade dependencies

* Remove NuGet pack tasks pkgref

* Add mega hack workaround

* Remove KnownFrameworkReference items

* Don't hardcode SDK value in helix submission...

* Update runtimeConfiguration.targets

* Fix double publishing error in mobile tests

* Set DotNetCliVersion to right version for aspnetcoreruntime

* Update sendtohelixhelp.proj

* Update sendtohelixhelp.proj

Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
17 files changed:
Directory.Build.props
eng/Tools.props
eng/Version.Details.xml
eng/Versions.props
eng/illink.targets
eng/targetingpacks.targets
eng/testing/linker/SupportFiles/Directory.Build.targets
eng/testing/linker/project.csproj.template
eng/testing/runtimeConfiguration.targets
eng/testing/tests.mobile.targets
global.json
src/coreclr/System.Private.CoreLib/CreateRuntimeRootILLinkDescriptorFile.targets
src/installer/tests/Assets/TestUtils/TestProjects.targets
src/libraries/Directory.Build.targets
src/libraries/pkg/test/frameworkSettings/net6.0/settings.targets
src/libraries/sendtohelixhelp.proj
src/tests/Common/helixpublishwitharcade.proj