ping: Fix race in free in receive path 75/155175/1
authorsubashab@codeaurora.org <subashab@codeaurora.org>
Fri, 23 Jan 2015 22:26:02 +0000 (22:26 +0000)
committerSeung-Woo Kim <sw0312.kim@samsung.com>
Thu, 12 Oct 2017 08:03:05 +0000 (17:03 +0900)
commit653756932975bded4c5a1e2b873650600b6778eb
tree575f67c9de8206c1cbd905c0ac3b4840211d57f5
parenta73c5170c20c7376bd30d23389e78e4569623d32
ping: Fix race in free in receive path

[ Upstream commit fc752f1f43c1c038a2c6ae58cc739ebb5953ccb0 ]

An exception is seen in ICMP ping receive path where the skb
destructor sock_rfree() tries to access a freed socket. This happens
because ping_rcv() releases socket reference with sock_put() and this
internally frees up the socket. Later icmp_rcv() will try to free the
skb and as part of this, skb destructor is called and which leads
to a kernel panic as the socket is freed already in ping_rcv().

-->|exception
-007|sk_mem_uncharge
-007|sock_rfree
-008|skb_release_head_state
-009|skb_release_all
-009|__kfree_skb
-010|kfree_skb
-011|icmp_rcv
-012|ip_local_deliver_finish

Fix this incorrect free by cloning this skb and processing this cloned
skb instead.

This patch was suggested by Eric Dumazet

Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Cc: Eric Dumazet <edumazet@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[sw0312.kim: cherry-pick from linux-3.10.y to apply CVE]
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Change-Id: I0d137abf0735314648cd2cdaabe5b818b6dff956
net/ipv4/ping.c