rtnetlink: check DO_SETLINK_NOTIFY correctly in do_setlink
authorXin Long <lucien.xin@gmail.com>
Sun, 15 Oct 2017 10:13:45 +0000 (18:13 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 16 Oct 2017 19:48:45 +0000 (20:48 +0100)
commit64ff90cc2e6f42596d7a0c37e41dc95292bb63b1
treee54399965691ebc190697fbfb461b07426bef3c2
parentdc709f375743ebf5c9326cc9b946f6f09a34ac44
rtnetlink: check DO_SETLINK_NOTIFY correctly in do_setlink

The check 'status & DO_SETLINK_NOTIFY' in do_setlink doesn't really
work after status & DO_SETLINK_MODIFIED, as:

  DO_SETLINK_MODIFIED 0x1
  DO_SETLINK_NOTIFY 0x3

Considering that notifications are suppposed to be sent only when
status have the flag DO_SETLINK_NOTIFY, the right check would be:

  (status & DO_SETLINK_NOTIFY) == DO_SETLINK_NOTIFY

This would avoid lots of duplicated notifications when setting some
properties of a link.

Fixes: ba9989069f4e ("rtnl/do_setlink(): notify when a netdev is modified")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: David Ahern <dsahern@gmail.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c