LoongArch, bpf: Use 4 instructions for function address in JIT
authorHengqi Chen <hengqi.chen@gmail.com>
Tue, 14 Feb 2023 15:26:33 +0000 (15:26 +0000)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 17 Feb 2023 16:43:07 +0000 (17:43 +0100)
commit64f50f6575721ef03d001e907455cbe3baa2a5b1
tree7c487fd3cc1be21498883f3e7c2290da88c13dcd
parent1fe4850b34ab512ff911e2c035c75fb6438f7307
LoongArch, bpf: Use 4 instructions for function address in JIT

This patch fixes the following issue of function calls in JIT, like:

  [   29.346981] multi-func JIT bug 105 != 103

The issus can be reproduced by running the "inline simple bpf_loop call"
verifier test.

This is because we are emiting 2-4 instructions for 64-bit immediate moves.
During the first pass of JIT, the placeholder address is zero, emiting two
instructions for it. In the extra pass, the function address is in XKVRANGE,
emiting four instructions for it. This change the instruction index in
JIT context. Let's always use 4 instructions for function address in JIT.
So that the instruction sequences don't change between the first pass and
the extra pass for function calls.

Fixes: 5dc615520c4d ("LoongArch: Add BPF JIT support")
Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Tested-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Link: https://lore.kernel.org/bpf/20230214152633.2265699-1-hengqi.chen@gmail.com
arch/loongarch/net/bpf_jit.c
arch/loongarch/net/bpf_jit.h