crypto: picoxcell - Fix potential race condition bug
authorMadhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Tue, 11 Aug 2020 12:30:24 +0000 (18:00 +0530)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 21 Aug 2020 04:47:50 +0000 (14:47 +1000)
commit64f4a62e3b17f1e473f971127c2924cae42afc82
tree03db6834bad7fda6911c38bcda706e8aafb91b76
parent8afa25aa833fbd4f3aa701cb42ebd52b1deef1d3
crypto: picoxcell - Fix potential race condition bug

engine->stat_irq_thresh was initialized after device_create_file() in
the probe function, the initialization may race with call to
spacc_stat_irq_thresh_store() which updates engine->stat_irq_thresh,
therefore initialize it before creating the file in probe function.

Found by Linux Driver Verification project (linuxtesting.org).

Fixes: ce92136843cb ("crypto: picoxcell - add support for the...")
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Acked-by: Jamie Iles <jamie@jamieiles.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/picoxcell_crypto.c