The plain Makefile was using -Wall, but the gyp build wasn't. This CL turns on
authorsenorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>
Thu, 19 May 2011 19:58:58 +0000 (19:58 +0000)
committersenorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>
Thu, 19 May 2011 19:58:58 +0000 (19:58 +0000)
commit64cc579efa7e416c7298ed159d76b074b283c0f9
tree67a25945efd79dd7e76afa3126c01032a4086891
parent9e0f2ee0333244de11cc8e41c667bc676bc3d1a5
The plain Makefile was using -Wall, but the gyp build wasn't.  This CL turns on
-Wall -Wextra and -Wno-unused in common.gypi.  This revealed a lot of warnings
(and some actual bugs), all of which I fixed here.  This is pretty mindless
stuff for the most part (order of intialization, missing initializers, && within
||, etc), but will allow us to build cleanly with -Wall and -Wextra (and
-Werror, if we so choose).

I put defaults into switches that were missing cases.  I could put in the actual
missing enums instead if that's desired.  I could also assert on missing enums
instead of break, if that's desired.  I wasn't sure how to test the stuff in
"animator", so that should be looked at a bit more closely.

Review URL:  http://codereview.appspot.com/4547055/

git-svn-id: http://skia.googlecode.com/svn/trunk@1386 2bbb7eff-a529-9590-31e7-b0007b416f81
41 files changed:
gpu/include/GrSamplerState.h
gpu/src/GrGpuGLFixed.h
gpu/src/GrStencil.cpp
gpu/src/GrTesselatedPathRenderer.cpp
gpu/src/gr_unittests.cpp
gyp/common.gypi
samplecode/ClockFaceView.cpp
samplecode/SampleAARects.cpp
samplecode/SampleAll.cpp
samplecode/SampleArc.cpp
samplecode/SampleAvoid.cpp
samplecode/SampleBitmapRect.cpp
samplecode/SampleComplexClip.cpp
samplecode/SampleDitherBitmap.cpp
samplecode/SampleDrawLooper.cpp
samplecode/SampleEffects.cpp
samplecode/SampleLayers.cpp
samplecode/SampleLineClipper.cpp
samplecode/SampleMeasure.cpp
samplecode/SamplePatch.cpp
samplecode/SamplePath.cpp
samplecode/SamplePolyToPoly.cpp
samplecode/SampleRegion.cpp
samplecode/SampleShaderText.cpp
samplecode/SampleSlides.cpp
samplecode/SampleText.cpp
samplecode/SampleTextEffects.cpp
samplecode/SampleTiling.cpp
samplecode/SampleVertices.cpp
src/animator/SkDisplayApply.cpp
src/animator/SkDisplayXMLParser.cpp
src/animator/SkDump.cpp
src/animator/SkScript.cpp
src/animator/SkScriptDecompile.cpp
src/animator/SkScriptRuntime.cpp
src/animator/SkScriptTokenizer.cpp
src/svg/SkSVGParser.cpp
src/utils/unix/SkOSWindow_Unix.cpp
src/views/SkBorderView.cpp
src/views/SkView.cpp
src/views/SkWidgetViews.cpp