Removing lookup_minimal_symbol_and_objfile
authorWeimin Pan <weimin.pan@oracle.com>
Tue, 29 May 2018 22:01:34 +0000 (22:01 +0000)
committerWeimin Pan <weimin.pan@oracle.com>
Tue, 29 May 2018 22:37:07 +0000 (22:37 +0000)
commit64cc34d87089ff24b43e0a8760be132b7afa6f34
tree731d4904334e28a8ae4c888fac4c387299a5c089
parente7ec8713ec12a633fcdfc5524c9ee050389b6f9d
Removing lookup_minimal_symbol_and_objfile

Function lookup_minimal_symbol_and_objfile iterates on all objfiles and
calls lookup_minimal_symbol for each of them, effectively searching in all
objfiles.  lookup_bound_minimal_symbol calls lookup_minimal_symbol with NULL,
which also effectively searches all objfiles.  AFAIK, they do exactly the same
thing, so we can get rid of one (and lookup_minimal_symbol_and_objfile happens
to be the most inefficient because it ends up n^2 on the number of objfiles).

Tested in both aarch64-linux-gnu and amd64-linux-gnu. No regressions.
gdb/ChangeLog
gdb/coff-pe-read.c
gdb/glibc-tdep.c
gdb/jit.c
gdb/minsyms.c
gdb/minsyms.h
gdb/printcmd.c