ethtool: avoiding integer overflow in ethtool_phys_id()
authorMaxim Korotkov <korotkov.maxim.s@gmail.com>
Tue, 22 Nov 2022 12:29:01 +0000 (15:29 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 24 Nov 2022 04:03:51 +0000 (20:03 -0800)
commit64a8f8f7127da228d59a39e2c5e75f86590f90b4
treec917c726746d4b2ce0d7f63f0b58d5bf5ceb9c53
parent2094dbbd82f9ef180385e6466f03c40a98a7dfde
ethtool: avoiding integer overflow in ethtool_phys_id()

The value of an arithmetic expression "n * id.data" is subject
to possible overflow due to a failure to cast operands to a larger data
type before performing arithmetic. Used macro for multiplication instead
operator for avoiding overflow.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20221122122901.22294-1-korotkov.maxim.s@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/ioctl.c