arm64/mm: Set only the PTE_DIRTY bit while preserving the HW dirty state
authorAnshuman Khandual <anshuman.khandual@arm.com>
Thu, 13 Jul 2023 07:15:18 +0000 (12:45 +0530)
committerWill Deacon <will@kernel.org>
Thu, 27 Jul 2023 10:17:23 +0000 (11:17 +0100)
commit6477c3886ae101367aae2e808caf71f7b0fcc18e
tree116886c5d7c40b409646a015e7ec310a67549f5c
parentd0ba961217e0ef8608e751a46902259ce4ff52b7
arm64/mm: Set only the PTE_DIRTY bit while preserving the HW dirty state

pte_mkdirty() creates dirty states both in SW and HW bits, which is really
not required, either in pte_wrprotect() or pte_modify() for preserving the
HW dirty state. Because pte_mkdirty() sets PTE_DIRTY and clears PTE_RDONLY
as pte_write() always evaluates to be true - otherwise pte_hw_dirty() will
not test out in the first place. Clearing PTE_RDONLY again is not required
here because the pte is already in pte_hw_dirty() but might soon loose its
dirty state thus requiring preservation in SW dirty bit i.e PTE_DIRTY.

Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Link: https://lore.kernel.org/r/20230713071518.628440-1-anshuman.khandual@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/include/asm/pgtable.h