net/8390: Fix msg_enable patch snafu
authorFinn Thain <fthain@telegraphics.com.au>
Mon, 19 Feb 2018 02:39:17 +0000 (21:39 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 21 Feb 2018 19:14:04 +0000 (14:14 -0500)
commit646fe03b0d5fb678f0901e25eb184ae8860744fa
tree18f8bb2053912c4743b226d55672c9568704ebdf
parent73219de29486637c82925e963380bda020e4edfb
net/8390: Fix msg_enable patch snafu

The lib8390 module parameter 'msg_enable' doesn't do anything useful:
it causes an ancient version string to be logged.

Remove redundant code that logs the same string.

In ne.c and wd.c, the value of ei_local->msg_enable is used before
being assigned. Use ne_msg_enable and wd_msg_enable, respectively.

Most of the other 8390 drivers never assign ei_local->msg_enable.
Use the 'msg_enable' module parameter from lib8390 as the default
value.

Eliminate the pointless static and local variables.

Clean up an indentation mistake.

All of these issues originated from the same patch.

Cc: Russell King <linux@armlinux.org.uk>
Fixes: c45f812f0280 ("8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature")
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/8390/ax88796.c
drivers/net/ethernet/8390/axnet_cs.c
drivers/net/ethernet/8390/etherh.c
drivers/net/ethernet/8390/hydra.c
drivers/net/ethernet/8390/lib8390.c
drivers/net/ethernet/8390/mac8390.c
drivers/net/ethernet/8390/mcf8390.c
drivers/net/ethernet/8390/ne.c
drivers/net/ethernet/8390/pcnet_cs.c
drivers/net/ethernet/8390/wd.c
drivers/net/ethernet/8390/zorro8390.c