Fix PR40644: miscompile indexed FP constant store
authorThomas Preud'homme <thomasp@graphcore.ai>
Thu, 3 Oct 2019 16:00:37 +0000 (17:00 +0100)
committerThomas Preud'homme <thomasp@graphcore.ai>
Tue, 5 Nov 2019 11:07:52 +0000 (11:07 +0000)
commit646896a442249380f74ff404e6dd26687f3dc6d9
treef6414e71b6d4c6448640538e49bfe2ba7f0cae70
parentcf581d7977c5c80e9f6cb6e304d7eb3d0792f360
Fix PR40644: miscompile indexed FP constant store

Summary:
Functions replaceStoreOfFPConstant() and OptimizeFloatStore() both
replace store of float by a store of an integer unconditionally. However
this generates wrong code when the store that is replaced is an indexed
or truncating store. This commit solves this issue by adding an early
return in these functions when the store being considered is not a
normal store.

Bug was only observed on out of tree targets, hence the lack of testcase
in this commit.

Reviewers: efriedma

Subscribers: hiraditya, arphaman, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D68420
llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp