Lolcode candidate: Both Expression and FunctionLiteral define an accessor is_parenthe...
authorvogelheim <vogelheim@chromium.org>
Fri, 24 Apr 2015 11:07:50 +0000 (04:07 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 24 Apr 2015 11:07:31 +0000 (11:07 +0000)
commit63f7fbfea64fc6102a8fad7e570d95976e297d9a
tree64d91d816ef085f25672ddee8e3f50bdda11902c
parent4f9bc2d1c352136713b6122c1e2ba54cb552d9ae
Lolcode candidate: Both Expression and FunctionLiteral define an accessor is_parenthesized(), which access different flags. FunctionLiteral derives from Expression.

Given
      FunctionLiteral* a; a->is_parenthesized()
const FunctionLiteral* b; b->is_parenthesized()

the first accesses FunctionLiteral::IsParenthesized, the second accesses Expression::IsParenthesizedField.

Since these are distinct uses, we could rename them based on their use:
- Expression::is_parenthesized -> is_single_parenthesized
  Count # of parenthesis, for parsing & error handling:
  no parenthesis -> single parenthesis -> multi parenthesis
- FunctionLiteral::eager_compile_hint()
  Hint from parser to compiler about whether the parser suggests this function for eager compilation.

BUG=

Review URL: https://codereview.chromium.org/1097723005

Cr-Commit-Position: refs/heads/master@{#28042}
src/ast.h
src/compiler.cc
src/parser.cc
src/preparser.h