net: microchip: sparx5: Fix potential null-ptr-deref in sparx_stats_init() and sparx5...
authorShang XiaoJing <shangxiaojing@huawei.com>
Mon, 14 Nov 2022 13:38:53 +0000 (21:38 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 16 Nov 2022 09:10:29 +0000 (09:10 +0000)
commit639f5d006e36bb303f525d9479448c412b720c39
tree4753b1ba10fc4022cfd7b4d7dccf9a5d1dd3932f
parentba86af3733aece88dbcee0dfebf7e2dcfefb2be4
net: microchip: sparx5: Fix potential null-ptr-deref in sparx_stats_init() and sparx5_start()

sparx_stats_init() calls create_singlethread_workqueue() and not
checked the ret value, which may return NULL. And a null-ptr-deref may
happen:

sparx_stats_init()
    create_singlethread_workqueue() # failed, sparx5->stats_queue is NULL
    queue_delayed_work()
        queue_delayed_work_on()
            __queue_delayed_work()  # warning here, but continue
                __queue_work()      # access wq->flags, null-ptr-deref

Check the ret value and return -ENOMEM if it is NULL. So as
sparx5_start().

Fixes: af4b11022e2d ("net: sparx5: add ethtool configuration and statistics support")
Fixes: b37a1bae742f ("net: sparx5: add mactable support")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/microchip/sparx5/sparx5_ethtool.c
drivers/net/ethernet/microchip/sparx5/sparx5_main.c