powerpc: Fix handling of strncmp with zero len
authorJeff Mahoney <jeffm@suse.com>
Wed, 17 Mar 2010 10:55:51 +0000 (10:55 +0000)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Wed, 7 Apr 2010 08:00:39 +0000 (18:00 +1000)
commit637a99022fb119b90fb281715d13172f0394fc12
treeecd77d0ce7499bb7af7b7a3cf508010552dcbb39
parent6d1bdd2afbed74b3adcf3a7aec49e430eeb6c5f3
powerpc: Fix handling of strncmp with zero len

Commit 0119536c, which added the assembly version of strncmp to
powerpc, mentions that it adds two instructions to the version from
boot/string.S to allow it to handle len=0. Unfortunately, it doesn't
always return 0 when that is the case. The length is passed in r5, but
the return value is passed back in r3. In certain cases, this will
happen to work. Otherwise it will pass back the address of the first
string as the return value.

This patch lifts the len <= 0 handling code from memcpy to handle that
case.

Reported by: Christian_Sellars@symantec.com
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
CC: <stable@kernel.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/lib/string.S