[MachO] Fix struct size assertion
authorShoaib Meenai <smeenai@fb.com>
Fri, 12 Nov 2021 23:10:59 +0000 (15:10 -0800)
committerShoaib Meenai <smeenai@fb.com>
Wed, 17 Nov 2021 00:30:31 +0000 (16:30 -0800)
commit637a3396b3f8292d2118973b90eff314c553f6d2
treeb243d56baa3207001d8e45c7770f098e695cfd8d
parentb715b79d54d5ca2d4e8c91089b8f6a9389d9dc48
[MachO] Fix struct size assertion

It was checking for 64-bit builds incorrectly. Unfortunately,
ConcatInputSection has grown a bit in the meantime, and I don't see any
obvious way to shrink it. Perhaps icfEqClass could use 32-bit hashes
instead of 64-bit ones, but xxHash64 is supposed to be much faster than
xxHash32 (https://github.com/Cyan4973/xxHash#benchmarks), so that sounds
like a loss. (Unrelatedly, we should really look at using XXH3 instead
of xxHash64 now.)

Reviewed By: #lld-macho, int3

Differential Revision: https://reviews.llvm.org/D113809
lld/MachO/InputSection.h