watchdog: imx7ulp: Add explict memory barrier for unlock sequence
authorJacky Bai <ping.bai@nxp.com>
Thu, 25 Aug 2022 08:32:51 +0000 (16:32 +0800)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 2 Oct 2022 10:55:44 +0000 (12:55 +0200)
commit6371593fbad75cfb9ee14e8b462a5ebb1aa38c02
tree2567f47141eaf5e5925bac663127cca15cd43172
parentf182683333b5d8ac4af64517b6e3c444c4579e6e
watchdog: imx7ulp: Add explict memory barrier for unlock sequence

When reconfiguring the WDOG Timer of i.MX7ULP, there is a certain
probability causes it to reset. The reason is that the CMD32EN of the
WDOG Timer of i.MX7ULP is disabled in bootloader. The unlock sequence
are two 16-bit writes to the CNT register within 16 bus clocks. Adding
mb() is to guarantee that two 16-bit writes are finished within 16 bus
clocks. Memory barriers cannot be added between these two 16-bit writes
so that writel_relaxed is used.

Suggested-by: Ye Li <ye.li@nxp.com>
Signed-off-by: Jacky Bai <ping.bai@nxp.com>
Signed-off-by: Alice Guo <alice.guo@nxp.com>
Reviewed-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20220825083256.14565-3-alice.guo@oss.nxp.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/imx7ulp_wdt.c